Remove consecutive platform defines #155
Conversation
There was a problem hiding this comment.
not disagreeing with this change, I think its a super good thing and cleans up something I hated
What I am not sure of is base_generator.py should start to become a util bin
it solo job I think should be to create VulkanObject... I feel this change in the future this would lead to just everyone wanting to add their non-related utils in this file
|
Sure, I can agree that it’s not great to have a dumping ground for utils. I’m not sure of a better place though, so I’m open to suggestions. |
|
the VVL has a |
Generated code must macro-guard platform specific code, but did it in a naive fashion where consecutive guards for the same platform repeated the macro. With the help of PlatformGuardHelper, the code generation will elide redundant macro guards.
charles-lunarg
force-pushed
the
remove_consecutive_platform_guards
branch
from
a571a9a to
29cfee0
Compare
|
I'll use camelCase because the rest of the project appears to use it. Easier to keep in line with everything else and if someone wants to change it in the future, they are more than welcome to. |
Generated code must macro-guard platform specific code, but did it in a naive fashion where consecutive guards for the same platform repeated the macro. With the help of PlatformGuardHelper, the code generation will elide redundant macro guards.