From d90f5c7eb1dcfe6ee21363d3c73200425eb6e8b8 Mon Sep 17 00:00:00 2001 From: Jeremy Gebben Date: Tue, 26 Mar 2024 16:51:16 -0600 Subject: [PATCH] scripts: Make gn.py use check_call Just like VVL, it was using subprocess.call(), which ignores errors. --- scripts/gn/gn.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) mode change 100644 => 100755 scripts/gn/gn.py diff --git a/scripts/gn/gn.py b/scripts/gn/gn.py old mode 100644 new mode 100755 index 52b20c5..f23106d --- a/scripts/gn/gn.py +++ b/scripts/gn/gn.py @@ -23,19 +23,19 @@ def BuildGn(): print("Updating Repo Dependencies and GN Toolchain\n", flush=True) update_cmd = './scripts/gn/update_deps.sh' - subprocess.call(update_cmd) + subprocess.check_call(update_cmd) print("Checking Header Dependencies\n", flush=True) gn_check_cmd = 'gn gen --check out/Debug'.split(" ") - subprocess.call(gn_check_cmd) + subprocess.check_call(gn_check_cmd) print("Generating Ninja Files\n", flush=True) gn_gen_cmd = 'gn gen out/Debug'.split(" ") - subprocess.call(gn_gen_cmd) + subprocess.check_call(gn_gen_cmd) print("Running Ninja Build\n", flush=True) ninja_build_cmd = 'ninja -C out/Debug'.split(" ") - subprocess.call(ninja_build_cmd) + subprocess.check_call(ninja_build_cmd) # # Module Entrypoint