Skip to content

Commit

Permalink
scripts: Make gn.py use check_call
Browse files Browse the repository at this point in the history
Just like VVL, it was using subprocess.call(), which ignores
errors.
  • Loading branch information
jeremyg-lunarg authored and charles-lunarg committed Mar 26, 2024
1 parent 4befdac commit d90f5c7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions scripts/gn/gn.py
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,19 @@ def BuildGn():

print("Updating Repo Dependencies and GN Toolchain\n", flush=True)
update_cmd = './scripts/gn/update_deps.sh'
subprocess.call(update_cmd)
subprocess.check_call(update_cmd)

print("Checking Header Dependencies\n", flush=True)
gn_check_cmd = 'gn gen --check out/Debug'.split(" ")
subprocess.call(gn_check_cmd)
subprocess.check_call(gn_check_cmd)

print("Generating Ninja Files\n", flush=True)
gn_gen_cmd = 'gn gen out/Debug'.split(" ")
subprocess.call(gn_gen_cmd)
subprocess.check_call(gn_gen_cmd)

print("Running Ninja Build\n", flush=True)
ninja_build_cmd = 'ninja -C out/Debug'.split(" ")
subprocess.call(ninja_build_cmd)
subprocess.check_call(ninja_build_cmd)

#
# Module Entrypoint
Expand Down

0 comments on commit d90f5c7

Please sign in to comment.