-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MSVC build. #984
Fix MSVC build. #984
Conversation
@bader Testing this on Visual Studio 2022, I could reproduce the error regarding the missing headers and can see |
The CI shows no error other than "Error: The operation was canceled" after six hours, which I presume is a timeout? Should I do something to get the CI to re-run? |
I've updated your branch, which fixed ccache configuration. It should pass now. No actions should be needed from your side. |
@hvdijk, thanks! @jiezzhang confirmed that this patch fixes the problem. |
In commit 33be1b1, I updated rounding_mode.* to their current OpenCL-CTS versions without noticing that the old versions had an intentional deviation from OpenCL-CTS: a call to vlog_error had been commented out, and the headers that were needed only for that were also left out. This commit reapplies those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In commit 33be1b1, I updated rounding_mode.* to their current OpenCL-CTS versions without noticing that the old versions had an intentional deviation from OpenCL-CTS: a call to vlog_error had been commented out, and the headers that were needed only for that were also left out. This commit reapplies those changes.