Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC build. #984

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix MSVC build. #984

merged 2 commits into from
Nov 25, 2024

Conversation

hvdijk
Copy link
Contributor

@hvdijk hvdijk commented Nov 13, 2024

In commit 33be1b1, I updated rounding_mode.* to their current OpenCL-CTS versions without noticing that the old versions had an intentional deviation from OpenCL-CTS: a call to vlog_error had been commented out, and the headers that were needed only for that were also left out. This commit reapplies those changes.

@hvdijk hvdijk requested a review from a team as a code owner November 13, 2024 10:08
@hvdijk
Copy link
Contributor Author

hvdijk commented Nov 13, 2024

@bader Testing this on Visual Studio 2022, I could reproduce the error regarding the missing headers and can see rounding_mode.cpp compiles with this change, but I am unable to link test binaries because of other unrelated errors which may be something in my setup. Are you able to test whether MSVC builds actually work properly on setups where they previously worked?

@hvdijk
Copy link
Contributor Author

hvdijk commented Nov 13, 2024

The CI shows no error other than "Error: The operation was canceled" after six hours, which I presume is a timeout? Should I do something to get the CI to re-run?

@bader
Copy link
Contributor

bader commented Nov 13, 2024

The CI shows no error other than "Error: The operation was canceled" after six hours, which I presume is a timeout? Should I do something to get the CI to re-run?

I've updated your branch, which fixed ccache configuration. It should pass now. No actions should be needed from your side.

@bader
Copy link
Contributor

bader commented Nov 14, 2024

@bader Testing this on Visual Studio 2022, I could reproduce the error regarding the missing headers and can see rounding_mode.cpp compiles with this change, but I am unable to link test binaries because of other unrelated errors which may be something in my setup. Are you able to test whether MSVC builds actually work properly on setups where they previously worked?

@hvdijk, thanks! @jiezzhang confirmed that this patch fixes the problem.

oclmath/rounding_mode.cpp Outdated Show resolved Hide resolved
In commit 33be1b1, I updated rounding_mode.* to their current
OpenCL-CTS versions without noticing that the old versions had an
intentional deviation from OpenCL-CTS: a call to vlog_error had been
commented out, and the headers that were needed only for that were also
left out. This commit reapplies those changes.
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit 30dae94 into KhronosGroup:main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants