Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting notification fails #682

Open
bielu opened this issue Nov 14, 2024 · 1 comment
Open

Detecting notification fails #682

bielu opened this issue Nov 14, 2024 · 1 comment

Comments

@bielu
Copy link
Contributor

bielu commented Nov 14, 2024

Describe the bug
i tried to follow https://docs.jumoo.co.uk/usync/uSync/extending/detecting, but both ways failed.

To Reproduce
Steps to reproduce the behavior:

  1. Create usync pack of media (or export files)
  2. attach notification to saving event
  3. Import usync pack of media (or import through usync dashboard)

Expected behavior
Being able to detect if content comes from usync (it shouldn't matter if it is from media or content)

Screenshots
If applicable, add screenshots to help explain your problem.

About your Site (please complete the following information):

  • Umbraco Version: 13.5.2
  • uSync Version: 13.2.5
  • Browser [e.g. chrome, safari]

Additional context
Add any other context about the problem here.

@bielu
Copy link
Contributor Author

bielu commented Nov 27, 2024

@KevinJump i have look into source code of both umbraco and usync, so the issue happens when you try to attach to cancellable notifications (Saving, Publishing), because your ScopedNotificationPublisher overriden only PublishScopedNotifications, where we would actually need to override PublishCancelableAsync and PublishCancelable to attach state to cancellable events, I can do pr to resolve it, but it I would need advise from you, as i can see in ScopedNotificationPublisher you done some background queining, do we want do it as well in other notifactions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant