Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 20241101_TypeScript로_안전하게_API_호출하기 - 윤예진 #97

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

Yejin0O0
Copy link
Contributor

@Yejin0O0 Yejin0O0 commented Nov 1, 2024

No description provided.

Copy link

@kciter kciter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요.

전체적으로 잘 작성하셨습니다. 몇 가지 부분만 추가적으로 보완하면 좋을 것 같아요.


프로젝트에서 백엔드와의 통신을 위해 fetch API를 활용하여 코드를 구현했습니다. GET API 요청을 위한 코드는 아래 사진과 같이 작성했습니다.

![image](https://github.com/user-attachments/assets/e91d379a-0c1c-4852-b957-adf8dc8fd368)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 코드는 이미지 대신 마크다운을 이용해 코드를 적어도 좋을 것 같습니다.




[참고문서]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 헤딩을 사용하면 좋겠습니다.

Comment on lines 40 to 42
function identity<T>(arg: T): T {
return arg;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특별히 identity 함수여야 하는 이유가 없다면 다른 예제는 어떨까요? 조금 더 제네릭의 특성이 보이는 예제 코드가 좋을 것 같습니다.

@day1companyhaewooklee day1companyhaewooklee merged commit 67a6977 into main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants