페이지 UI: 차량 부가정보 페이지 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bottlewook
added
✨ Feature
Closed
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seoye0ng
reviewed
Jan 20, 2024
src/remote/api/types/details.ts
Outdated
There was a problem hiding this comment.
details말고 additional info나 additional details는 어떤가요? 더 명확하게 알 수 있을 것 같아요!
seoye0ng
reviewed
Jan 20, 2024
| useEffect(() => { | ||
| const id = setTimeout(() => { | ||
| router.push('/'); | ||
| }, 2000); |
There was a problem hiding this comment.
2초로 하드코딩 되어있는데 기간을 정의하는 상수를 사용하는 것은 어떤가요? (크게 상관은 없지만 기간을 따로 정의해놓으면 관리하기 편할 것 같아요!)
seoye0ng
reviewed
Jan 20, 2024
| } | ||
|
|
||
| &:checked ~ span { | ||
| color: var(--primary) !important; |
There was a problem hiding this comment.
혹시 이 부분에서 !impotant가 꼭 필요할까요?? 음 다른 방향으로 스타일을 적용할 수 있다면 최대한 사용하지 않는 게 좋을 것 같아요!
There was a problem hiding this comment.
그게 Text 컴포넌트가 인라인으로 폰트 색상을 받아서 그래요.. css 우선순위에 따라 focus 됐을 때 색상을 지정하려면 기존에 있던 인라인 속성을 오버라이딩 해야하는데 그 방법이 !important밖에 없었습니다 ㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers