공통 컴포넌트: Modal #42
Merged
공통 컴포넌트: Modal #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…/F1-WashPedia-FE into common-component-modal
seoye0ng
reviewed
Jan 6, 2024
|
|
||
| return ( | ||
| <Dimmed> | ||
| <div className={cx('container')} ref={modalRef}> |
There was a problem hiding this comment.
시맨틱 태그를 위해서 모달 컨텐츠는 article태그나 dialog태그는 어떤가요??
There was a problem hiding this comment.
레퍼런스 많이 찾아봤는데 div 태그를 많이 사용하시길래 저도 div로 작성했어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers