페이지 UI: 즐겨찾기 페이지 #124
Merged
페이지 UI: 즐겨찾기 페이지 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
2 tasks
bottlewook
requested changes
Jan 24, 2024
src/app/favorite/page.tsx
Outdated
|
|
||
| import classNames from 'classnames/bind'; | ||
|
|
||
| import useScroll from '@/hooks/useScroll'; |
There was a problem hiding this comment.
Suggested change
| import useScroll from '@/hooks/useScroll'; | |
| import useScroll from '@hooks/useScroll'; |
| setIsScrolled(window.scrollY > 1); | ||
| }; | ||
|
|
||
| window.addEventListener('scroll', handleScroll); |
There was a problem hiding this comment.
스크롤 이벤트가 감지되면 handleScroll 함수가 매번 실행되기 때문에 throttle을 적용해서 성능 개선하는 건 어떨까요!
There was a problem hiding this comment.
이거 라이브러리 불러오려다가 git rebase했더니.. 이전 커밋 로그까지 같이 찍혀버렸네요...흑흑... throttle 적용했습니다!
src/app/favorite/page.tsx
Outdated
| <div> | ||
| <> | ||
| <Header isDisplayLogo={false}>즐겨찾기</Header> | ||
| <Spacing size={8} /> |
There was a problem hiding this comment.
피그마에선 12px로 되어있네요 채은님께 말씀드려 통일시켜보죠!
| margin: 13px 0 24px; | ||
| } | ||
|
|
||
| .productArticleContainer { |
There was a problem hiding this comment.
무한 스크롤로 인해 productArticle이 엄청 쌓이게 되면 애니메이션 효과가 버벅임 없이 동작하는지 한번 봐야할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers