Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

공통 컴포넌트: Header UI 변경 #84

Merged
merged 18 commits into from
Jan 18, 2024
Merged

Conversation

seoye0ng
Copy link
Collaborator

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • TEST : 테스트 추가 및 리팩토링
  • FIX : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • STYLE : 코드 스타일에 관련된 변경 사항
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • CHORE : 패키지 매니저 설정, 코드 수정 없이 설정 변경(eslint) 등 기타 사항

설명

  1. 메인페이지 Header UI 수정
  2. icon 변경 및 추가
  3. storybook 수정

Key Changes

How it Works

To Reviewers

@seoye0ng seoye0ng added the 🎨 Html&css 마크업 & 스타일링 label Jan 16, 2024
@seoye0ng seoye0ng self-assigned this Jan 16, 2024
@seoye0ng seoye0ng requested a review from bottlewook as a code owner January 16, 2024 10:07
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
f1-wash-pedia-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 1:58pm

@seoye0ng seoye0ng linked an issue Jan 16, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@bottlewook bottlewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
헤더가 많이 바뀌고 있네요ㅠ🫠

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일명 filledHeart로 바꿔주세요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일명 FilledHeart로 바꿔주세요~

</li>
{displayRightIcon && (
<li>
<Text>홈</Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

즐겨찾기 페이지에서 사용될 즐겨찾기 문구도 추가해야할 것 같아요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이프로필 페이지에서도 문구가 계속 바뀌네요.. props로 바꿔야할 것 같아요!🫠
스크린샷 2024-01-17 오전 2 56 42

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 이부분 수정하겠습니다!

@seoye0ng seoye0ng requested a review from bottlewook January 17, 2024 13:59
Copy link
Collaborator

@bottlewook bottlewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@seoye0ng seoye0ng merged commit 79c616b into develop Jan 18, 2024
6 checks passed
@seoye0ng seoye0ng deleted the edit-component-header branch January 18, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Html&css 마크업 & 스타일링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

공통 컴포넌트: Header UI 수정
2 participants