-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
페이지 UI: 로그인 #74
페이지 UI: 로그인 #74
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
@@ -0,0 +1,7 @@ | |||
function Loginlayout({ children }: { children: React.ReactNode }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저번에 말씀드린 것처럼 페이지가 모두 완성되면 한번에 처리하죠!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
src/app/login/page.tsx
Outdated
const cx = classNames.bind(styles); | ||
|
||
function LoginPage() { | ||
const { register, handleSubmit } = useForm<ISignUp>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 수정해서 올리겠습니다!
@@ -46,7 +46,7 @@ const TextField = forwardRef<HTMLInputElement, TextFieldProps>(function TextFiel | |||
isPasswordType={isPasswordType} | |||
{...props} | |||
/> | |||
{hasError ? <Spacing size={6} /> : <Spacing size={12} />} | |||
{hasError ? <Spacing size={6} /> : <Spacing size={20} />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다~
color: var(--tertiary); | ||
font-size: 12px; | ||
|
||
&:not(:last-child)::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳굳!
src/app/login/page.tsx
Outdated
<ul className={cx('linkContainer')}> | ||
<li> | ||
<Link href="/"> | ||
<span>회원가입</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 단순 궁금증인데 span 태그를 빼고 아래처럼 작성하면 형태가 이상해지나요?🤔
<Link href="/">회원가입</Link>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 이거 Link가 스타일이 안먹어서 span썻었는데 다른 방법으로 해결하고 지우는걸 까먹었네요ㅋㅋㅋ 수정해서 바로 커밋하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨어요!
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers