Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

페이지 UI: 로그인 #74

Merged
merged 4 commits into from
Jan 14, 2024
Merged

페이지 UI: 로그인 #74

merged 4 commits into from
Jan 14, 2024

Conversation

seoye0ng
Copy link
Collaborator

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • TEST : 테스트 추가 및 리팩토링
  • FIX : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • STYLE : 코드 스타일에 관련된 변경 사항
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • CHORE : 패키지 매니저 설정, 코드 수정 없이 설정 변경(eslint) 등 기타 사항

설명

Key Changes

  1. 로그인 페이지 UI 제작

How it Works

To Reviewers

@seoye0ng seoye0ng added ✨ Feature 기능 개발 🎨 Html&css 마크업 & 스타일링 labels Jan 13, 2024
@seoye0ng seoye0ng self-assigned this Jan 13, 2024
@seoye0ng seoye0ng requested a review from bottlewook as a code owner January 13, 2024 14:26
Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
f1-wash-pedia-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 2:45pm

@seoye0ng seoye0ng linked an issue Jan 13, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@bottlewook bottlewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@@ -0,0 +1,7 @@
function Loginlayout({ children }: { children: React.ReactNode }) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저번에 말씀드린 것처럼 페이지가 모두 완성되면 한번에 처리하죠!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!

const cx = classNames.bind(styles);

function LoginPage() {
const { register, handleSubmit } = useForm<ISignUp>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 페이지는 id와 password만 필요하니 ISignIn을 import 해주세요!
스크린샷 2024-01-14 오전 11 00 39

submithandler 타입 정의하기 링크
스크린샷 2024-01-14 오전 11 07 46

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 수정해서 올리겠습니다!

@@ -46,7 +46,7 @@ const TextField = forwardRef<HTMLInputElement, TextFieldProps>(function TextFiel
isPasswordType={isPasswordType}
{...props}
/>
{hasError ? <Spacing size={6} /> : <Spacing size={12} />}
{hasError ? <Spacing size={6} /> : <Spacing size={20} />}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~

color: var(--tertiary);
font-size: 12px;

&:not(:last-child)::after {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳굳!

<ul className={cx('linkContainer')}>
<li>
<Link href="/">
<span>회원가입</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 단순 궁금증인데 span 태그를 빼고 아래처럼 작성하면 형태가 이상해지나요?🤔
<Link href="/">회원가입</Link>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 이거 Link가 스타일이 안먹어서 span썻었는데 다른 방법으로 해결하고 지우는걸 까먹었네요ㅋㅋㅋ 수정해서 바로 커밋하겠습니다!

Copy link
Collaborator

@bottlewook bottlewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!

@seoye0ng seoye0ng merged commit c1b7bbc into develop Jan 14, 2024
6 checks passed
@seoye0ng seoye0ng deleted the page-login branch January 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발 🎨 Html&css 마크업 & 스타일링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

페이지 제작: 로그인 페이지
2 participants