Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with keyboard layout switches #151

Open
lwouis opened this issue Feb 22, 2023 · 2 comments
Open

Issues with keyboard layout switches #151

lwouis opened this issue Feb 22, 2023 · 2 comments
Labels

Comments

@lwouis
Copy link

lwouis commented Feb 22, 2023

Hello,

Someone reported an issue with switching keyboard layout between Finnish and US with AltTab. I debugged and ended up pinning the issue to a simple call to the SRShortcut initializer.

With keyboard layout set to US:

Shortcut(keyEquivalent: shortcutString)
// prints: Optional(;)

With keyboard layout set to Finnish:

Shortcut(keyEquivalent: shortcutString)
// prints: nil

When checking on the Inspector app, it seems that the keyEquivalent is ; when keyboard layout is set to Finnish:

image

The initializer returning nil seems like a bug to me, but maybe I'm misunderstanding something.

It also seems to me that the SRRecorderControl should also not show ; after the keyboard layout switches to Finnish. The other values show Ö. I think it should show that. It actually shows it dimmed if the user clicks to set the control:

image

What do you think?

Thank you 🙇‍♂️

@lwouis
Copy link
Author

lwouis commented Nov 6, 2024

Hi @Kentzo,
If you have time, could you please look at this issue? It looks like it could be a quick-win since it's specific and I've narrowed it down already.
Thank you 🙇

@Kentzo
Copy link
Owner

Kentzo commented Nov 18, 2024

@lwouis Will try to work on this before end of the month.

@Kentzo Kentzo added the bug label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants