mroonga: tests: prevents error if sourcedir is readonly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An out-of-tree build where the the source is readonly results the following cmake error. The source tree for out-of-tree builds should be immutable. As the version number isn't of particular importance remove the dependance of the tests finding the exact same version. CMake Error: Could not open file for write in copy operation /source/storage/mroonga/mysql-test/mroonga/storage/r/information_schema_plugins.result.tmp CMake Error: : System Error: Read-only file system CMake Error at storage/mroonga/CMakeLists.txt:437 (configure_file): configure_file Problem configuring file CMake Error: Could not open file for write in copy operation /source/storage/mroonga/mysql-test/mroonga/storage/r/variable_version.result.tmp CMake Error: : System Error: Read-only file system CMake Error at storage/mroonga/CMakeLists.txt:441 (configure_file): configure_file Problem configuring file mroonga - remove version from test
|
Acceptable? |
|
Hi, is this an acceptable change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An out-of-tree build where the the source is readonly results the
following cmake error. The source tree for out-of-tree builds
should be immutable.
As the version number isn't of particular importance remove the
dependence of the tests finding the exact same version.
CMake Error: Could not open file for write in copy operation /source/storage/mroonga/mysql-test/mroonga/storage/r/information_schema_plugins.result.tmp
CMake Error: : System Error: Read-only file system
CMake Error at storage/mroonga/CMakeLists.txt:437 (configure_file):
configure_file Problem configuring file
CMake Error: Could not open file for write in copy operation /source/storage/mroonga/mysql-test/mroonga/storage/r/variable_version.result.tmp
CMake Error: : System Error: Read-only file system
CMake Error at storage/mroonga/CMakeLists.txt:441 (configure_file):
configure_file Problem configuring file
Moved here from MariaDB#655 as requested.
I submit this under the MCA.