Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scopes are not allowed error without scopes #278

Closed
cengels opened this issue Feb 16, 2024 · 1 comment · Fixed by #281
Closed

scopes are not allowed error without scopes #278

cengels opened this issue Feb 16, 2024 · 1 comment · Fixed by #281
Assignees
Labels
bug Something isn't working

Comments

@cengels
Copy link

cengels commented Feb 16, 2024

Describe the bug

Followup of #273. An input like echo "feat: something" | commitlint unexpectedly emits a scopes are not allowed error, even though a scope is not used in the commit message.

Config

rules:
  scope:
    level: error
    options: []
  scope-empty:
    level: ignore

Error message

scopes are not allowed

Expected behavior

No error.

Version

$ commitlint --version
commitlint-rs 0.1.8

Additional context

Trying the same with types.options: [] doesn't seem to work properly either, but let's be honest, permitting scopes but not types makes absolutely no sense at all, so I wouldn't really consider this a problem.

@cengels cengels added the bug Something isn't working label Feb 16, 2024
@KeisukeYamashita KeisukeYamashita self-assigned this Feb 16, 2024
@KeisukeYamashita
Copy link
Owner

Thank you very much for your report!
Now, it generates no error 🙏

echo "feat: something" | commitlint
=> None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants