Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset applied to longslit edges causes crash for 46-slit longslits #144

Open
mheida opened this issue Jul 21, 2020 · 0 comments
Open

Offset applied to longslit edges causes crash for 46-slit longslits #144

mheida opened this issue Jul 21, 2020 · 0 comments

Comments

@mheida
Copy link

mheida commented Jul 21, 2020

I ran into this issue while reducing data taken with a full 46 unit longslit mask. AutoDriver produces a description of the longslit with an upper and lower boundary, which includes a 10 pixel offset to the calculated values. For the 46 unit slit that gives boundaries of [10, 2058], and that causes the make_pixel_flat to crash with an index error because the maximum index is 2048. I suppose this is really only an issue for the 46 unit longslit, and it's an easy manual fix, but it might be worth capping that upper boundary at 2048 in AutoDriver or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant