Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if variance properly computed in L1 #953

Open
awhoward opened this issue Oct 28, 2024 · 2 comments
Open

Check if variance properly computed in L1 #953

awhoward opened this issue Oct 28, 2024 · 2 comments
Assignees

Comments

@awhoward
Copy link
Collaborator

awhoward commented Oct 28, 2024

Based on an initial examination, it appears that the variance in the 2D files (which includes contributions from signal and read noise) is not being properly computed in the L1 files. For L1 files, it seems that variance is just computed as abs(signal), not the sum of variance over the extracted 2D region (possibly using weights per pixel in the extracted stripe depending on the extraction method).

@awhoward awhoward self-assigned this Oct 28, 2024
@awhoward
Copy link
Collaborator Author

Here's an example comparing the variance and flux arrays for SKY in a 15-min observation of a faint target (Kepler-1654, V=13.4). It appears that variance = abs(flux). We should fix this.
Screenshot 2024-10-28 at 1 29 27 PM

@awhoward
Copy link
Collaborator Author

I think it's in the compute_variance() method referenced on line 444 of this code. I can't find where SpectralExtraction even computes the variance for each extracted L1 pixel from a region of the variance array in the corresponding 2D array.

I'm putting a note here for myself or someone else as I need to step away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant