Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion of the correct trace when reducing multiple instrument configurations simultaneously #136

Open
yuguangchen1 opened this issue Jun 23, 2022 · 0 comments

Comments

@yuguangchen1
Copy link

Hi!

There is a bug about which trace table to use when multiple instrument configurations are reduced together.

In "ExtractArcs.py", the following code is causing the issue:

        if hasattr(self.context, 'trace'):
            trace = self.context.trace
        else:
            trace = read_table(
                input_dir=os.path.join(self.config.instrument.cwd,
                                       self.config.instrument.output_directory),
                file_name=original_filename)
            self.context.trace = {}
            for key in trace.meta.keys():
                self.context.trace[key] = trace.meta[key]

This is fine when only one instrument configuration is used. However, when multiple configurations are reduced at the same time, self.context.trace is overwritten by another configuration before it is used to extract arcs. Therefore, the trace tables should always be read from the directory.

We provide a hotfix at: prusinski@16ca8e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant