Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saturation check not performed? #135

Open
yuguangchen1 opened this issue Jun 20, 2022 · 1 comment
Open

Saturation check not performed? #135

yuguangchen1 opened this issue Jun 20, 2022 · 1 comment

Comments

@yuguangchen1
Copy link

Hi!

I just noticed that the current version of the pipeline seems to miss the saturation check.

The IDL pipeline performs the check at stage 1, right after the images are loaded and before the bias subtraction. However, this step is missing in the current pipeline between "ProcessObject" and "SubtractBias" primitives. Therefore, the flag extension if the "_int.fits" files does not contain flags==1 pixels, which was correctly identified in the IDL pipeline.
@yuguangchen1
Copy link
Author

FYI. We provide a hotfix of this issue in our forked version: prusinski@5b2f6e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuguangchen1