Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering NDArray pointclouds #23

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

wbthomason
Copy link
Contributor

Title. Adds an overload of the Python binding filter_pointcloud, and refactors the C++ implementation to work with a zero-cost wrapper of the original std::vector of points or a nanobind NDArray type.

Copy link
Contributor

@zkingston zkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the update.

@zkingston zkingston merged commit 32bee20 into main Aug 12, 2024
8 of 9 checks passed
@zkingston zkingston deleted the feat/numpy-pointcloud-filter branch August 12, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants