ISSUE-675: sanitize filename in video recorder #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersanin
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev,
Nikitae57 and
CherchesovAzamat
as code owners
ersanin
force-pushed
the
ISSUE-675-Filenames-Sanitization-In-VideoRecorder
branch
from
10c2bcb
to
debbb0b
Compare
| @@ -12,7 +12,10 @@ class VideosImpl( | |||
| ) : Videos { | |||
|
|
|||
| override fun record(tag: String) { | |||
| val videoFile: File = resourceFilesProvider.provideVideoFile(tag) | |||
| val sanitizedVideoName = tag | |||
There was a problem hiding this comment.
Will this be a breaking change or not?
There was a problem hiding this comment.
If we believe the comment in the original isse, then this changes fix only the broken case
Nikitae57
requested changes
Nov 21, 2024
| @@ -12,7 +12,10 @@ class VideosImpl( | |||
| ) : Videos { | |||
|
|
|||
| override fun record(tag: String) { | |||
| val videoFile: File = resourceFilesProvider.provideVideoFile(tag) | |||
| val sanitizedVideoName = tag | |||
| .replace("[/:\"*?<>|]+".toRegex(), "") | |||
There was a problem hiding this comment.
- The issue creator used backing slash to cover each special simbol. It's not needed?
- Please, replace with the undescrore. User expected a simbol there
- Please, if the video name changed, then leave a warning log with something like
log("Can't record video with name $tag since it contains one of the following special characters [/:\"*?<>|]. Changing the name to $sanitizedVideoName")
There was a problem hiding this comment.
- We don't need this. IDE marks these special symbols as redundant.
- Done
- Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.