Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.kavitaignore no more #2442

Merged
merged 11 commits into from
Nov 19, 2023
Merged

.kavitaignore no more #2442

merged 11 commits into from
Nov 19, 2023

Conversation

majora2007
Copy link
Member

@majora2007 majora2007 commented Nov 19, 2023 •
edited
Loading

image

Added

  • Added: Library Settings now has File types setting which allows you to turn on/off different types of file types from the scanner.
  • Added: Library Settings now has an exclude patterns control which allows you to ignore folders or file patterns.

Changed

  • Changed: .kavitaignore files have been deprecated and will log a warning to the logs whenever one is found. They will currently still function but be removed in the v0.8 release.

Closes #2394

@majora2007
Stashing the code as I found a potential bug/performance improvement …
09a7f35 
…that I want to explore.
@majora2007
Not tonight.
8eb6cb3
@majora2007
Hooked up the ability to default the types of files and also to overr…
4f206ce 
…ide whenever type is set.
@majora2007
Removed the old migration files. Added a migration for the new types …
f78f33e 
…and hooked up the UI for file types only.
@majora2007
Hooked up the new file type group code in the scan loop. Ready for ne…
0ea226c 
…w globbing code.
@majora2007
Updated unit tests, all passing.
1ef3d89
@majora2007
Refactored the weblinks on edit series modal out to a dedicated compo…
69e1c8b 
…nent.
@majora2007
Everything but the scanner part is hooked up and maybe will need some…
37a7307 
… light validation on the UI.
@majora2007
Kavitaignore functionality is fully supported through Library setting…
0687d6b 
…s and a warning is added to inform the user that the file-based support will be removed soon.
@majora2007
Cleaned up the UI code a bit. Feature should be complete.
251977f
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 19, 2023
View reviewed changes
UI/Web/src/app/cards/_modals/edit-series-modal/edit-series-modal.component.ts Outdated
}
return chapter.number;
updateWeblinks(items: Array<string>) {
this.metadata.webLinks = items.map(s => s.replace(',', '%2C')).join(',');

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of ','.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@majora2007 majora2007 merged commit 7221501 into develop Nov 19, 2023
5 checks passed
@majora2007 majora2007 deleted the feature/library-settings-extended branch November 19, 2023 18:15
@janaxhell
Copy link

janaxhell commented Nov 24, 2024 •
edited
Loading

According to the wiki

**/folder/* will ignore the folder at any depth in a path

I have many series folders that contain an /Extra subfolder with HTML presentation full of gifs/jpegs and such. With .kavitaignore I used Extra/* and all seemed to work fine. Now I have tried the same pattern in the UI, but it doesn't work, so I tried the above example as **/Extra/*
and it doesn't work as well. I have manually removed the bogus "series", rescanned with that exclusion and they came back.
My hierarchy is
/comics/country/publisher/series/Extra
with all the .cbz files at the same level of /Extra in
/comics/country/publisher/series/

image

I'm using latest 0.8.4.0

@majora2007
Copy link
Member Author

According to the wiki

**/folder/* will ignore the folder at any depth in a path

I have many series folders that contain an /Extra subfolder with HTML presentation full of gifs/jpegs and such. With .kavitaignore I used Extra/* and all seemed to work fine. Now I have tried the same pattern in the UI, but it doesn't work, so I tried the above example as **/Extra/* and it doesn't work as well. I have manually removed the bogus "series", rescanned with that exclusion and they came back. My hierarchy is /comics/country/publisher/series/Extra with all the .cbz files at the same level of /Extra in /comics/country/publisher/series/

image

I'm using latest 0.8.4.0

This is not the correct place to bring up a bug. Please file a new issue. Otherwise this will not be worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of .kavitaignore
2 participants
@majora2007 @janaxhell