Skip to content

Polish Part 3

Polish Part 3 #80

Triggered via pull request November 10, 2023 13:56
Status Success
Total duration 9m 29s
Artifacts 1

develop-workflow.yml

on: pull_request
Upload Kavita.Common for Version Bump
21s
Upload Kavita.Common for Version Bump
Bump version
25s
Bump version
Build Nightly Docker
8m 12s
Build Nightly Docker
Fit to window
Zoom out
Zoom in

Annotations

14 warnings
Upload Kavita.Common for Version Bump
The process '/usr/bin/git' failed with exit code 128
Bump version
The process '/usr/bin/git' failed with exit code 128
Build Nightly Docker
The following actions uses node12 which is deprecated and will be forced to run on node16: rjstone/discord-webhook-notify@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build Nightly Docker: Kavita.Common/Configuration.cs#L20
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
Build Nightly Docker: Kavita.Common/Configuration.cs#L20
Change the visibility of 'KavitaPlusApiUrl' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223)
Build Nightly Docker: Kavita.Common/Configuration.cs#L20
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
Build Nightly Docker: Kavita.Common/Configuration.cs#L323
Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218)
Build Nightly Docker: Kavita.Common/Configuration.cs#L325
Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218)
Build Nightly Docker: Kavita.Common/Configuration.cs#L327
Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218)
Build Nightly Docker: Kavita.Common/EnvironmentInfo/IOsInfo.cs#L15
Initialize all 'static fields' inline and remove the 'static constructor'. (https://rules.sonarsource.com/csharp/RSPEC-3963)
Build Nightly Docker: Kavita.Common/Helpers/UntrustedCertClientFactory.cs#L10
Enable server certificate validation on this SSL/TLS connection (https://rules.sonarsource.com/csharp/RSPEC-4830)
Build Nightly Docker: API/Data/Metadata/ComicInfo.cs#L138
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build Nightly Docker: API/Data/Repositories/AppUserProgressRepository.cs#L146
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
Build Nightly Docker
The process '/usr/bin/git' failed with exit code 128

Artifacts

Produced during runtime
Name Size
csproj Expired
948 Bytes