From 0c6a30d96cf3d666a69b31cacb1d7957c7cbf860 Mon Sep 17 00:00:00 2001 From: Christopher Chang <51393127+chriscerie@users.noreply.github.com> Date: Wed, 18 Oct 2023 13:00:03 -0700 Subject: [PATCH] Change deprecated to maybeincorrect --- selene-lib/src/lints/constant_table_comparison.rs | 6 +----- selene-lib/src/lints/deprecated.rs | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/selene-lib/src/lints/constant_table_comparison.rs b/selene-lib/src/lints/constant_table_comparison.rs index 356c84b8..087a6dac 100644 --- a/selene-lib/src/lints/constant_table_comparison.rs +++ b/selene-lib/src/lints/constant_table_comparison.rs @@ -58,11 +58,7 @@ impl Lint for ConstantTableComparisonLint { "comparing to a constant table will always fail".to_owned(), Label::new(comparison.range), suggestion.clone(), - if suggestion.is_some() { - Applicability::MaybeIncorrect - } else { - Applicability::Unspecified - }, + Applicability::MaybeIncorrect, ) }) .collect() diff --git a/selene-lib/src/lints/deprecated.rs b/selene-lib/src/lints/deprecated.rs index 95d01f38..1d2dd1fb 100644 --- a/selene-lib/src/lints/deprecated.rs +++ b/selene-lib/src/lints/deprecated.rs @@ -132,7 +132,7 @@ impl<'a> DeprecatedVisitor<'a> { notes, Vec::new(), fixed_code, - Applicability::MachineApplicable, + Applicability::MaybeIncorrect, )); } }