Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future improvements #23

Open
jaromiru opened this issue Jun 27, 2018 · 4 comments
Open

Future improvements #23

jaromiru opened this issue Jun 27, 2018 · 4 comments

Comments

@jaromiru
Copy link

jaromiru commented Jun 27, 2018

First, hands down, amazing work. Serving as a baseline, I see a possible improvement, if someone wants to implement it:

@Kaixhin
Copy link
Owner

Kaixhin commented Jun 27, 2018

Thanks a lot, I can say the same for your blog 🙂In my spare time I'm still looking for bugs, as I still have issues with some learning on some games (Pong and Breakout being particularly worrying).

In any case I won't be able to work on extending Rainbow for a while, but if anyone is interested I've leaving master for a pure Rainbow implementation and extensions for anything others want to add as options (I added quantile regression as an exercise to myself, but I haven't tested it within Rainbow at all, so it's possible that it's harmful here).

Edit: False alarm on Pong at least

@marintoro
Copy link

Hello,

I am reopening this really old issue to just ask a question.
Did you test the QR extension on other game than Pong? (and even better did you try to implement Implicit Quantile Networks? ^^)

@Kaixhin
Copy link
Owner

Kaixhin commented Oct 11, 2018

Nope - I just did that as an implementation exercise to myself, so I've not actually tested it at all (the comment about Pong was about normal Rainbow at the time). I'm not planning to do any further development, but I am trying to test normal Rainbow on a few more games/upload the pretrained models for people to use.

@heartInsert
Copy link

I also noice that the Rainbow performs veyr bad in Pong , extremly strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants