Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve linting for license #5

Open
rgantonio opened this issue Sep 14, 2023 · 2 comments
Open

Resolve linting for license #5

rgantonio opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@rgantonio
Copy link

In github workflows, the license checker is tailored towards PULP checking. We need to make a separate one for our side OR need to resolve the licensing checks for files that do not have licenses. For now we add in the exclude list the files we don't want to change.

Check: https://github.com/KULeuven-MICAS/snitch_cluster/blob/main/.github/workflows/lint.yml

#################
# Check License #
#################
license-lint:
  name: Check License headers
  runs-on: ubuntu-latest
  steps:
    - name: Check License
      uses: pulp-platform/pulp-actions/[email protected]
      with:
        patches: 0001-Allow-hash-comments-in-assembly.patch
        # We cover ETH Zurich and lowRISC licenses and Apache 2.0
        # (mostly for SW) and Solderpad for the hardware.
        # yamllint disable rule:line-length
        license: |
          Copyright (\d{4}(-\d{4})?\s)?(ETH Zurich and University of Bologna|lowRISC contributors).
          (Solderpad Hardware License, Version 0.51|Licensed under the Apache License, Version 2.0), see LICENSE for details.
          SPDX-License-Identifier: (SHL-0.51|Apache-2.0)
        # yamllint enable rule:line-length
        match_regex: true
        exclude_paths: |
          sw/snRuntime/src/omp/interface.h
          sw/math/arch/generic/*
          sw/math/arch/riscv64/bits/*
          sw/math/include/*
          sw/math/src/include/*
          sw/math/src/internal/*
          sw/math/src/math/*
          sw/math/Makefile
          hw/snitch/src/csr_snax_def.sv
@rgantonio rgantonio added the help wanted Extra attention is needed label Sep 14, 2023
@rgantonio rgantonio self-assigned this Sep 14, 2023
@JosseVanDelm
Copy link

@rgantonio can you check 4da1804, and see whether that fixes your issue?

@JosseVanDelm
Copy link

Ping @rgantonio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants