-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge clipping incomplete #7
Comments
Looking a little closer, it seems like the distance threshold set on line 108 is not actually used in the subsequent point selection using rangesearch a few lines down. Instead, a fixed value of 1.0 is used. Using the actual threshold value set as a 15th percentile seems to always be too small (less than the default 1). It seem like this radius should be an exposed parameter or dynamically set and increased until a proper clipping of the bridge is achieved. After playing around a bit here is what I found that worked.
I then changed the code that identifies the nodes of the path to actually use this threshold
|
Looping in @lisapankewitz as this is code added in CobivecoX Congrats on your recently accepted paper! https://doi.org/10.1016/j.media.2024.103091 |
Dear Jake, thanks so much for this feedback! This issue can be a bit tricky sometimes, due to the local curvature of the inflow outflow tracts especially in certain cases on the LV, I found. I appreciate sharing your findings. I will include this in my next pull request! @axel-loewe Thanks so much!!! I am submitting a major Pull request this week, once I have the feedback of the proof. Just wanted to avoid you going through several major PRs. It will reflect the code changes and a few additional documentation changes. |
Hi Jake, |
I seem to be running across an issue in the definition of the bridges between valves. For example, the TV to PV bridge is clipped using the paths defined in the image below. On the epicardium it seems that the distance threshold used to define the paths was insufficient to fully cut the bridge as there is a gap in the path.
The paths on the endocardium appear to be contiguous, but when they are projected to the epicardium they are discontinuous.
endo paths:
Epi points:
The defineBridgesShortestPath.m function seems to take this into account, on line 107:
% use tenths percentile as threshold for distance search
But it seems that the tenths percentile is not enough in this case. Any suggestions on how to resolve this would be appreciated.
The text was updated successfully, but these errors were encountered: