Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix FastMTT memory leak #269

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix FastMTT memory leak #269

merged 2 commits into from
Jun 5, 2024

Conversation

harrypuuter
Copy link
Contributor

This PR fixes the FastMTT memory leak observed in the current main function

Before:
grafik

After:
grafik

@harrypuuter harrypuuter requested a review from nshadskiy June 5, 2024 13:52
nshadskiy
nshadskiy reviewed Jun 5, 2024
View reviewed changes
src/SVFit/FastMTT.cxx Outdated Show resolved Hide resolved
nshadskiy
nshadskiy approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@nshadskiy nshadskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! See one small comment.

@harrypuuter harrypuuter merged commit ca0ef40 into main Jun 5, 2024
6 of 7 checks passed
@harrypuuter harrypuuter deleted the fastmtt_fix branch June 5, 2024 14:56
zhiyuanlcern pushed a commit to zhiyuanlcern/CROWN that referenced this pull request Jun 7, 2024
@harrypuuter @zhiyuanlcern
fix FastMTT memory leak (KIT-CMS#269)
b064351 
* fix FastMTT memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshadskiy nshadskiy nshadskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrypuuter @nshadskiy