Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payload deployment, ROOT 6.30 #241

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Payload deployment, ROOT 6.30 #241

merged 5 commits into from
Jan 19, 2024

Conversation

harrypuuter
Copy link
Contributor

This PR adds several small changes

  • Update to LCG 105 using ROOT 6.30
  • Add analysis_configuration/$ANALYSIS/payloads folder to the installdir, if available. Within the CROWN config, files from the payloads folder can be accessed using payloads/path/to/file. (@nfaltermann )
  • Fixed a bug, where the CROWNLIB was not requild, requiring a removal of the libfile (@conformist89 )

@harrypuuter
Copy link
Contributor Author

pls let me know, if anything breaks when using ROOT 6.30

nfaltermann
nfaltermann reviewed Jan 16, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@conformist89
Copy link
Member

It works good to me, compatible with ROOT 6.30 and crownlib bug seems to be corrected now

@harrypuuter harrypuuter merged commit 5b6cdfc into main Jan 19, 2024
4 of 7 checks passed
@harrypuuter harrypuuter deleted the lcg_105 branch January 19, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfaltermann nfaltermann nfaltermann left review comments

@conformist89 conformist89 conformist89 approved these changes

@ralfschmieder ralfschmieder Awaiting requested review from ralfschmieder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrypuuter @conformist89 @nfaltermann