You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on code review last week it would be nice to make terminal color handling in
cli/kaos_cli/commands/build.py
in the same way, as we have it in other modules (train, serve, etc...):
@build.command(name='deploy',
short_help='{}'.format(
click.style('Build the kaos backend', bold=True, fg='black')))
->
@serve.command(name='deploy',
short_help='Configure and serve an ML model')
How will this change improve kaos?
No point to have command's color hardcoded (maybe apart of kill command warning).
As we saw on the code review demo - it could be invisible because of a terminal different color scheme.
Any thoughts on the implementation approach?
Refactoring
The text was updated successfully, but these errors were encountered:
What is the desired change?
Based on code review last week it would be nice to make terminal color handling in
cli/kaos_cli/commands/build.py
in the same way, as we have it in other modules (train, serve, etc...):
->
How will this change improve kaos?
No point to have command's color hardcoded (maybe apart of
kill
command warning).As we saw on the code review demo - it could be invisible because of a terminal different color scheme.
Any thoughts on the implementation approach?
Refactoring
The text was updated successfully, but these errors were encountered: