KDT0_LeeYeongUk #60
Open
KDT0_LeeYeongUk #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkey-kim
reviewed
Aug 25, 2023
Comment on lines
+1
to
+12
| export default function validation(data) { | ||
| const {name, email, team, job, position, img} = data | ||
|
|
||
| if ( | ||
| name === "" || email === "" || team === "" || | ||
| job === "" || position === "" || img === "" | ||
| ) { | ||
| return false | ||
| } else { | ||
| return true | ||
| } | ||
| } |
There was a problem hiding this comment.
직원등록페이지에서 빈칸체크하는데 쓰신 로직같은데, 짧고 깔끔한 코드인 것 같아요!
추후에 회원가입기능이나 로그인 기능 만들 때 참고할 수 있을 것 같습니다👍
zoeyourlife
reviewed
Aug 25, 2023
Comment on lines
+1
to
+16
| import Component from "../../core/Component"; | ||
|
|
||
| export default class CreateButton extends Component { | ||
| constructor() { | ||
| super({ | ||
| tagName: "button" | ||
| }) | ||
| } | ||
| render() { | ||
| this.el.classList.add("create-button") | ||
| this.el.innerText = "임직원 생성" | ||
| this.el.addEventListener("click", () => { | ||
| location.href = '#/create' | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
전반적으로 각 기능 별로 컴포넌트화 해서 개발하신 코드라 디렉토리 구조 보기도 편하고 좋았습니다.
|
GraphQL 사용하신 부분이 인상적이었습니다! 이전까지는 아무런 고민 없이 REST API만을 사용하곤 하였는데요. 그 전의 경험을 되돌아보니 원하는 것은 객체 내 특정 필드 일부분인데 단순 조회 요청을 통해 너무 많은 데이터를 받아오게 되거나, 한 객체에 대한 정보로는 내용이 부족해 다른 객체에 대한 조회 요청까지 보내게 되었던 아쉬움이 있었습니다. 그 과정에서 불필요한 요청도 많아지게 되고, 무엇보다 사용자 경험에도 직접적인 영향을 주게 되었던 것 같습니다. |
iamidlek
reviewed
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.