Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain list suggestions #8

Open
vstepaniuk opened this issue Jun 18, 2017 · 4 comments
Open

Domain list suggestions #8

vstepaniuk opened this issue Jun 18, 2017 · 4 comments

Comments

@vstepaniuk
Copy link

  1. Is it possible to use wildcard characters (* and ?) in the domain list? For instance, for site.com, site.org, site.net, etc. to use just site.* (yes, all existing domains..) ?
  2. Could you please add some details on the domain list rules in the field description
    (besides "Use ; as separator to list multiple domains")? Thank you.
  3. Why is semicolon used as a delimiter? Is it possible also/instead to use comma?
  4. Is it possible to make domain list a multi-line field, with a new line character as a delimiter? It would be much easier to read it and edit then.
    Thank you
@JustOff
Copy link
Owner

JustOff commented Jun 18, 2017

  1. Is it possible to use wildcard characters (* and ?) in the domain list? For instance, for site.com, site.org, site.net, etc. to use just site.* (yes, all existing domains..) ?

Wildcards are implicitly supported for subdomains (i.e. site.tld always matches to *site.tld), but if you want to match site.* you can use the following sintax: site.[a-z]+.

  1. Could you please add some details on the domain list rules in the field description
    (besides "Use ; as separator to list multiple domains")? Thank you.

It seems to me that there are no meaningful details that could be added there, let's keep the field description brief.

  1. Why is semicolon used as a delimiter? Is it possible also/instead to use comma?

I see no reason to change the delimiter, why do you need this?

  1. Is it possible to make domain list a multi-line field, with a new line character as a delimiter? It would be much easier to read it and edit then.

Firefox does not support multi-line fields in inline options.

@vstepaniuk
Copy link
Author

vstepaniuk commented Jun 18, 2017

  1. You could have at least mentioned that wildcards are implicitly supported for subdomains (i.e. site.tld always matches to *site.tld) .

@JustOff
Copy link
Owner

JustOff commented Jun 18, 2017

Ok, I'll consider this when preparing the next release.

@KrasnayaPloshchad
Copy link

I also suggest adding a functionality to import domain list from the Internet. There is an nice list that you can try, however you also have to add support for base64 decoding.
https://github.com/gfwlist/gfwlist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants