Use hypot in haversine calculation for more floating-point safety
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypot(x, y) is sqrt(x^2 + y^2) but implemented in an error-corrected way. It is a bit slower though, so depends on the tradeoff you want to make. Feel free to accept or reject.
dkarrasch
reviewed
Oct 29, 2024
| @@ -24,10 +24,11 @@ function (dist::Haversine)(x, y) | |||
| Δφ = φ₂ - φ₁ # latitudes | |||
|
|
|||
| # haversine formula | |||
| a = sind(Δφ/2)^2 + cosd(φ₁)*cosd(φ₂)*sind(Δλ/2)^2 | |||
| # hypot(x, y) is equivalent to sqrt(x^2 + y^2) | |||
| sqrt_a = hypot(sind(Δφ/2), cosd(φ₁)*cosd(φ₂)*sind(Δλ/2)) | |||
There was a problem hiding this comment.
This is incorrect. The cosd coefficients are not squared, it's just the sind term.
There was a problem hiding this comment.
Ah whoops, I missed that somehow! This is probably not very useful then :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hypot(x, y) is sqrt(x^2 + y^2) but implemented in an error-corrected way. It is a bit slower though, so depends on the tradeoff you want to make. Feel free to accept or reject.