Fix-up i686/armv7 support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, Julia will potentially notice the high bit of the pointer is set and complain about an inexact conversion.
This gets me down to ~5-6 instructions of overhead on x86 and armv7: ```julia julia> println(Sys.ARCH); @pstats "(instructions,branch-instructions,branch-misses)" nothing arm ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ┌ instructions 6.00e+00 100.0% │ branch-instructions 1.00e+00 100.0% # 16.7% of insns └ branch-misses 0.00e+00 100.0% # 0.0% of branch insns ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ``` ```julia julia> println(Sys.ARCH); @pstats "(instructions,branch-instructions,branch-misses)" nothing i686 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ┌ instructions 5.00e+00 100.0% │ branch-instructions 2.00e+00 100.0% # 40.0% of insns └ branch-misses 1.00e+00 100.0% # 50.0% of branch insns ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ```
topolarity
force-pushed
the
ct/fixup-32-bit
branch
7 times, most recently
from
d111fae to
337fccb
Compare
topolarity
force-pushed
the
ct/fixup-32-bit
branch
from
337fccb to
e4ce93a
Compare
|
Do we have runners for all the arches you're trying to test? |
|
I'm not entirely sure we do - it also looks like our PowerPC machines have a higher I'll ping some CI folks and see what we should use |
We'll have to wait until someone would like to setup CirrusCI (https://github.com/ararslan/CirrusCI.jl) to get AArch64 tested, but for now this at least means we have one 32-bit arch covered which is still a big improvement.
|
Sounds like we need https://github.com/ararslan/CirrusCI.jl to get better platform support, but I'm happy just to have 32-bit coverage of any kind for now so let's merge this with the x86-64 + i686 CI only |
Zentrik
approved these changes
Oct 7, 2024
carstenbauer
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets 32-bit working properly (finally), and brings us down to ~5-6 instructions of overhead on x86 and armv7: