Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml for Mac aarch64 and use Julia-actions/cache to improve caching #199

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Oct 16, 2024

macOS-latest is now aarch64 - so separate out that build recipe in an include to make sure it picks the right architecture. Otherwise, it is just testing x64 in emulation on ARM.

macOS-13 is x64 (but I am not sure if it is native or not). We could probably drop that too, since Apple stopped shipping those a few years ago - but people do still have them.

Also changing the version to test with 1 which tests with the latest stable release. Running lts only on linux should suffice to ensure we don't accidentally break it. This will all reduce CI load while the package is under heavy development.

`macOS-latest` is now aarch64 - so separate out that build recipe in an include to make sure it picks the right architecture. Otherwise, it is just testing x64 in emulation on ARM.

macOS-13 is x64 (but I am not sure if it is native or not). We could probably drop that too, since Apple stopped shipping those a few years ago - but people do still have them.
@ViralBShah ViralBShah changed the title Update ci.yml for Mac aarch64 Update ci.yml for Mac aarch64 and use Julia-actions/cache to improve caching Oct 16, 2024
@ViralBShah
Copy link
Member Author

@boriskaus Are you ok with this? If so, let's merge when green.

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 16, 2024

On Julia 1.11, I am routinely seeing test failures in test_dmstag.jl in CI. It feels like some kind of race condition, since rerunning the workflow once or twice does get it to pass.

DM Vectors and Coordinates |  360    360  0.8s
free(): invalid next size (normal)
[2012] signal 6 (-6): Aborted
in expression starting at /home/runner/work/PETSc.jl/PETSc.jl/test/test_dmstag.jl:314

@boriskaus
Copy link
Collaborator

Yes I noticed this too and wonder if it is only in test_dmstag

@ViralBShah
Copy link
Member Author

It has always been in test_dmstag every time I saw it.

The new julia-actions/cache seems to be working nicely and shaving off some CI time.

@ViralBShah ViralBShah merged commit 7e7bc54 into main Oct 16, 2024
4 checks passed
@ViralBShah ViralBShah deleted the ViralBShah-patch-1 branch October 16, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants