Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valuepairs #15

Open
zsunberg opened this issue Sep 30, 2019 · 3 comments
Open

valuepairs #15

zsunberg opened this issue Sep 30, 2019 · 3 comments

Comments

@zsunberg
Copy link
Member

Currently, we have actionvalues to get a vector of values, one for each action in the POMDP. Making sure these values always match up to the right actions seems rather error prone; it might be more helpful to have a valuepairs function that returns a list of action-value pairs so no one can get confused about which action each value corresponds to.

@rejuvyesh
Copy link
Member

The vector representation is likely more efficient for DeepRL algorithms.

@MaximeBouton
Copy link
Contributor

So far we managed the order internally by either having an actionmap field in the policy object or by making sure we use ordered_actions. I agree that it could be confusing, especially if actionindex does not agree with the ordering from whatever actions returns.
valuepairs would raise any ambiguity, not sure about the name.

@zsunberg
Copy link
Member Author

zsunberg commented Oct 1, 2019

The vector representation is likely more efficient for DeepRL algorithms.

Yes, though only very slightly if things are type-stable. I think we should have both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants