Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review naming scheme to align with POMDPs.jl #29

Open
lassepe opened this issue Oct 8, 2019 · 1 comment
Open

Review naming scheme to align with POMDPs.jl #29

lassepe opened this issue Oct 8, 2019 · 1 comment

Comments

@lassepe
Copy link
Member

lassepe commented Oct 8, 2019 •
edited
Loading

This is only a cosmetic change but IMHO things like obs_weight should rather be called obsweight at some point. It would be more consistent with our general naming pattern (e.g. initialobs instead of initial_obs in POMDPs.jl).
@zsunberg
Copy link
Member

zsunberg commented Oct 9, 2019

Yeah, we should probably review all the names in POMDPModelTools and upgrade them at once

@lassepe lassepe changed the title obs_weight should be called obsweight Review naming scheme to align with POMDPs.jl Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zsunberg @lassepe