Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to ensure operations involving the constants defined here keep constant folding #37

Open
nsajko opened this issue Oct 29, 2024 · 1 comment

Comments

@nsajko
Copy link
Contributor

nsajko commented Oct 29, 2024

The PR JuliaLang/julia#55886 stripped generic AbstractIrrational operations of their effect annotations. As a bugfix, it will be part of future v1.10, v1.11 and v1.12 Julia releases. This means that operations like Rational{Int}(twoπ) won't constant fold.

There are several possible fixes for this issue, including defining effect annotations in this package, or, in some cases, hardcoding the return values.

@devmotion
Copy link
Member

We could just add it to the macro, that's the only official way for defining new irrational constants anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants