Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NarrowTypes transform that converts columns to the most specific types possible #75

Closed
juliohm opened this issue May 10, 2022 · 2 comments
Assignees
Labels
feature good first issue Good for newcomers

Comments

@juliohm
Copy link
Member

juliohm commented May 10, 2022

Add a transform that takes a table with possibly generic column eltypes and returns a new table with specific column types.

@juliohm juliohm added feature good first issue Good for newcomers labels May 10, 2022
@eliascarv eliascarv self-assigned this Jun 11, 2022
@eliascarv
Copy link
Member

eliascarv commented Jun 13, 2022

The PR #96 depends on fixing the following issue from the Transducers.jl package:
JuliaFolds/Transducers.jl#524
Implementation will be delayed until this issue is fixed.

@juliohm juliohm changed the title NarrowTypes Add NarrowTypes transform that converts columns to the most specific types possible Nov 27, 2023
@juliohm
Copy link
Member Author

juliohm commented Dec 13, 2023

I think we don't need this transform. We can assume that the user will load a table with appropriate narrow types, and that our pipelines will ensure type propagation. If something is not working as expected due to some compiler or language limitation, we can refactor the code to achieve the desired results.

@juliohm juliohm closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants