Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg.dependencies() triggers write_env_usage #4082

Open
fonsp opened this issue Nov 13, 2024 · 0 comments
Open

Pkg.dependencies() triggers write_env_usage #4082

fonsp opened this issue Nov 13, 2024 · 0 comments

Comments

@fonsp
Copy link
Member

fonsp commented Nov 13, 2024

While debugging performance issues in https://github.com/JuliaPluto/PlutoSliderServer.jl we found that the Pkg.dependencies() call is quite heavy and was causing IO performance issues. Some profiling showed that write_env_usage was the cause.

I understand that more information on the write_env_usage performance problem would be really useful, but in the meantime I just wanted to ask:

Is it intentional that the call Pkg.dependencies() gets recorded in manifest_usage.toml? I feel like Pkg.dependencies() should not have any side effects. I also don't think it is necessary to record this as "manifest usage", since Pkg.dependencies() is mainly used by scripts and doesn't necessarily signal "usage" by a person.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant