Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of finding stationary points #88

Closed
wants to merge 8 commits into from
Closed

Conversation

dpsanders
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #88 into master will decrease coverage by 6.51%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   64.97%   58.45%   -6.52%     
==========================================
  Files          11       11              
  Lines         551      544       -7     
==========================================
- Hits          358      318      -40     
- Misses        193      226      +33
Impacted Files Coverage Δ
src/quadratic.jl 88.88% <ø> (-7.41%) ⬇️
src/root_object.jl 14.28% <ø> (-10.72%) ⬇️
src/newton.jl 0% <ø> (ø) ⬆️
src/krawczyk.jl 0% <ø> (ø) ⬆️
src/newton1d.jl 70.9% <100%> (-16.37%) ⬇️
src/linear_eq.jl 66.21% <61.53%> (-18.92%) ⬇️
src/IntervalRootFinding.jl 7.89% <75%> (+3.24%) ⬆️
src/roots.jl 81.03% <85.71%> (-7.11%) ⬇️
src/contractors.jl 97.5% <96.77%> (+7.5%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0027a...30e5771. Read the comment docs.

X = IntervalBox( (-L..L+1), 2)

@time rts = IntervalRootFinding.roots(∇f, X, Bisection)
@time rts = IntervalRootFinding.roots(∇f, rts, Newton, 1e-20)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two @time can be removed. I'll add them as benchmark to #105.

Also with minor adaptation Krawczyk method could be checked here too (a bit to involved change for GitHub propose change feature though).

test/stationary_points.jl Outdated Show resolved Hide resolved
Kolaru and others added 5 commits February 2, 2019 13:15
* Base.Test -> Test

* Fix some deprecations

* Fix a Smiley test and more deprecations

* Fix linear alebra tests

* New iteration protocol

* Remove lexcmp

* Update REQUIRE, .travis.yml and appveyor.yml for 0.7 and 1.0

* Pedal back ForwardDiff requirement
* Fix bug with log function

* Fix contraction typo

Co-Authored-By: Kolaru <[email protected]>

* Add failing tests

* Fix other test issues

* Naively fix log(y/x) bug

* Clean contractor code

* Fix typos and cosmetic changes

* Use metaprograming to avoid code duplication
@dpsanders dpsanders mentioned this pull request Feb 5, 2019
Kolaru added a commit to Kolaru/IntervalRootFinding.jl that referenced this pull request Nov 6, 2024
@Kolaru Kolaru mentioned this pull request Nov 6, 2024
@Kolaru
Copy link
Collaborator

Kolaru commented Nov 6, 2024

Superseded by #205

@Kolaru Kolaru closed this Nov 6, 2024
Kolaru added a commit that referenced this pull request Nov 6, 2024
* Add test from #88 for #87

* Add root at infinity test

* Merge stationary point tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants