-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency in validity check during interval creation #468
Comments
Hopefully these tables help in the discussion
For
Currently, parse uses make_interval which uses atomic, hence it is not possible to construct an interval from a string without the "extra smartness" of |
I believe this issue has been in resolved with #560. |
From a discussin started here: #461 (comment)
Currently decorated interval always check for validity (it is in the
DecoratedInterval
constructor) while for bare interval one need to useinterval
instead of the type constructor. It may be confusing for users and feel inconsistent.One way around would be to have
Interval
always check by default and define a specialunsafe_interval
that doesn't perform any check and that we could use efficiently internally. Like that the types constructors would be safe for both bare and decorated intervals.The internal constructors could look something like this:
The text was updated successfully, but these errors were encountered: