Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-dimensional registration #13

Open
mileslucas opened this issue Jul 27, 2022 · 5 comments
Open

Multi-dimensional registration #13

mileslucas opened this issue Jul 27, 2022 · 5 comments

Comments

@mileslucas
Copy link
Member

The original Julia version of this package had support for multi-dimensional registration (e.g., registering a 3-D cube instead of a 2-D image). This was removed for simpler code, but should be added back as long as it doesn't negatively affect the performance of the 2-D registration.

@RpfR2000
Copy link

@mileslucas have you attempted to add this feature to the code? What is different about the 3D case?

@mileslucas
Copy link
Member Author

No I have not attempted this- feel free to try yourself if you'd like. I believe it's just an extension of the Fourier transforms into more dimensions than two.

@RpfR2000
Copy link

It looks like the only thing that needs to change is the upsampled_dft function; in particular, we need some kind of equivalent of _data = kernel * _data' for data with 3 dims (adjoint is only defined in 2 dims). It would be a tensor product I guess? Is there something like that in Julia?

@RpfR2000
Copy link

nevermind, I figured it out. I'll make a PR soon

@trollichon
Copy link

it would be so noce to have the multi-dimensional functionality back. It worked very nicely on 3d MRI data.
@RpfR2000 Any chance you might like to share your solution ?
In any case, thanks for this nice package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants