Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix periodic kernel AD #531
Fix periodic kernel AD #531
Changes from 2 commits
8329e3c
57a24b4
43d1f3a
ea5156d
a8baa31
498cdd8
9e598d5
8f01fc4
691921e
cb3a7f3
afe209c
fbc1fd6
73d940d
d0c889c
1118c90
c15d095
92b4576
6add335
006393d
16a3d02
774ac73
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 117 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L115-L117
Check warning on line 119 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L119
Check warning on line 124 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that rbar supports
setindex!
which is not true in general.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this case, it is because the field of
Sinus
is aVector
.Check warning on line 153 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L130-L153
Check warning on line 155 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L155
Check warning on line 157 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L157
Check warning on line 160 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L160
Check warning on line 193 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L167-L193
Check warning on line 195 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L195
Check warning on line 197 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L197
Check warning on line 200 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L200
Check warning on line 222 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L206-L222
Check warning on line 224 in src/chainrules.jl
Codecov / codecov/patch
src/chainrules.jl#L224