Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointless index-returns from all_neighbors #55

Open
hkraemer opened this issue Sep 15, 2020 · 2 comments
Open

Pointless index-returns from all_neighbors #55

hkraemer opened this issue Sep 15, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hkraemer
Copy link
Contributor

hkraemer commented Sep 15, 2020

The function all_neighbors returns pointless indices and according nearest neighbor values of -Inf, when the Theiler window and the length of the dataset do not allow an approariate declaration of Knearest neighbors. Specifically, that happens, when the Theiler window is large compared to the time series length. It would be better to assert that this does not happen, or at least throw a meaningful error in this case.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Datseris
Copy link
Member

Hm, I agree with you that all_neighbors should just throw an error when this happens. Easy to fix with a PR I feel!

@Datseris Datseris added bug Something isn't working good first issue Good for newcomers labels Sep 15, 2020
@Datseris
Copy link
Member

You can throw errors with error("Whatever message")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants