Allow OpenSSH @9

[eschnett]

Closes #73

Supersedes eschnett#1

[eschnett]

I checked the output of OpenSSH_jll.ssh_keygen for the new version 9, and there doesn't seem to be any difference to previous versions.

[eschnett]

@mortenpi Can you approve the CI workflow?

[mortenpi]

LGTM. Could you also bump the patch version and add a brief note to CHANGELOG.md? We can then tag a new version right away.

[eschnett]

@mortenpi Done. Can you approve the new CI workflow?

[eschnett]

@mortenpi Can you approve the CI workflow?

[mortenpi]

It looks like OpenSSH v9 doesn't work on Windows? If we'd get the Windows CI to pass, then this could be merged and tagged as far as I'm concerned.

[eschnett]

This is difficult to debug for me since I don't have access to a Windows machine.

Given that there is no error message on stdout or stderr, I conjecture that ssh-keygen.exe did not actually start. This could point to a problem with shared libraries.

Maybe this JuliaPackaging/Yggdrasil#7204 will correct the problem.

[giordano]

This is difficult to debug for me since I don't have access to a Windows machine.

Usual reminder that https://github.com/mxschmitt/action-tmate is a thing.

For the record, the problem may be this missing libcrypto.dll

julia> using DependencyWalker

julia> Library(OpenSSH_jll.ssh_keygen_path)
◼ C:\Users\runneradmin\.julia\artifacts\bed08e38e883f52775d130e1f289ee06485dbc6c\bin\ssh-keygen.exe
  ◼ C:\Windows\System32\CRYPT32.dll
  ✗ libcrypto.dll (NOT FOUND)
  ◼ C:\Windows\System32\USER32.dll
    ◼ C:\Windows\System32\GDI32.dll
    ◼ C:\Windows\System32\KERNELBASE.dll
  ◼ C:\Windows\System32\WS2_32.dll
    ◼ C:\Windows\System32\RPCRT4.dll
      ◼ C:\Windows\System32\KERNELBASE.dll
  ◼ C:\Windows\System32\KERNEL32.DLL
    ◼ C:\Windows\System32\KERNELBASE.dll
  ◼ C:\Windows\System32\ADVAPI32.dll
    ◼ C:\Windows\System32\KERNEL32.DLL
      ◼ C:\Windows\System32\KERNELBASE.dll
    ◼ C:\Windows\System32\RPCRT4.dll
      ◼ C:\Windows\System32\KERNELBASE.dll
    ◼ C:\Windows\System32\msvcrt.dll
      ◼ C:\Windows\System32\KERNELBASE.dll
    ◼ C:\Windows\System32\KERNELBASE.dll
    ◼ C:\Windows\System32\sechost.dll
      ◼ C:\Windows\System32\bcrypt.dll

[giordano]

JuliaPackaging/Yggdrasil#9482 should fix the issue

[giordano]

I opened #91 to resolve the merge conflicts.