Adds an options to use listings for code highlighting in LaTeX
#2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
changed the title
listings for code highlighting in LaTeX
mortenpi
reviewed
Dec 2, 2023
| @@ -266,15 +282,15 @@ end | |||
| # as the top-level blocks of a page, or somewhere deeper in the AST. | |||
| istoplevel(n::Node) = !isnothing(n.parent) && isa(n.parent.element, MarkdownAST.Document) | |||
|
|
|||
| latex(io::Context, node::Node) = latex(io, node, node.element) | |||
| latex(io::Context, node::Node, e) = error("$(typeof(e)) not implemented: $e") | |||
| latex(io::Context, node::Node; settings::LaTeX=LaTeX()) = latex(io, node, node.element; settings=settings) | |||
There was a problem hiding this comment.
We don't want to pass things through via the keyword arguments. That's what the Context object it for.
There was a problem hiding this comment.
I'm sorry, I am not sure I see what you mean. I don't see how a Context can be used to pass the compiler options or else. Could you elaborate ?
Co-authored-by: Morten Piibeleht <[email protected]>
|
@mortenpi I really did not have time to push this further so far... What can I do to revive this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2309