Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenter version extraction in rundocumenter.jl fails for new manifest format #192

Open
mortenpi opened this issue Feb 22, 2023 · 0 comments

Comments

@mortenpi
Copy link
Member

This part

documenter_version = v"0.24.10"
try
manifest = joinpath(docsdir, "Manifest.toml")
if isfile(manifest)
pm = Pkg.TOML.parsefile(manifest)
global documenter_version = VersionNumber(first(pm["Documenter"])["version"])
else
@warn("No Mainfest.toml found at `$(manifest)`. Defaulting to $(documenter_version).")
end
catch err
@error(exception = err)
end

generally leads to a KeyError("Documenter") because the new Manifest.toml format wraps all the packages in [deps.PackageName]. So we should probably do pm["deps"]["Documenter"] to extract the package (but probably also check manifest_format?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant