Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: support deploying documentation to another repo #97

Open
johnnychen94 opened this issue Jul 29, 2021 · 0 comments
Open

notebook: support deploying documentation to another repo #97

johnnychen94 opened this issue Jul 29, 2021 · 0 comments

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Jul 29, 2021

This only affects the nbview URL; other functionalities are not affected.

Currently, DemoCards hardcodes the jupyter nbview URL repo_slug with the repo URL that CI is running on instead of the URL of the target repo:

https://github.com/johnnychen94/DemoCards.jl/blob/4318c787d898edfa1592618d0a6aa65e4b80a637/src/generate.jl#L502-L515

This means if we deploy the documentation to another repo, then the nbview URLs are incorrect. For example, docs CI for ReinforcementLearning.jl deploys the documentation to using a custom script: https://github.com/JuliaReinforcementLearning/ReinforcementLearning.jl/blob/b6f93d75580972c7d4cf882e9274f383f4d62a99/.github/workflows/ci.yml#L105-L113

Cref: JuliaReinforcementLearning/ReinforcementLearning.jl#418

cc: @findmyway

@johnnychen94 johnnychen94 changed the title support deploying documentation to another repo notebook: support deploying documentation to another repo Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant