Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cover image was not properly handled when using a relative path #146

Open
TCLiuu opened this issue Apr 21, 2023 · 1 comment
Open

The cover image was not properly handled when using a relative path #146

TCLiuu opened this issue Apr 21, 2023 · 1 comment

Comments

@TCLiuu
Copy link

TCLiuu commented Apr 21, 2023

When the image path referenced in the example is a relative path, it cannot be processed correctly. For example,

![](../figures/cover.png)

Will produce an error, and the result will be like

┌ Warning: cover file doesn't exists
│   cover_path = "<CARD_PATH>/../figures/cover.png"
└ @ DemoCards ~/.julia/packages/DemoCards/ZgH8l/src/generate.jl:358

I think the problem arises from

src_path = joinpath(dirname(card.path), card.cover)

@frankier
Copy link
Collaborator

This report is a bit unclear. Does cover_path really exist on your system? Does it print literally "<CARD_PATH>" or is that your own replacement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants