Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode 'sh' / 'cmd' shells #4

Open
nickolay opened this issue Jul 27, 2020 · 1 comment
Open

Don't hardcode 'sh' / 'cmd' shells #4

nickolay opened this issue Jul 27, 2020 · 1 comment

Comments

@nickolay
Copy link

Hey, thanks for making this tool, looks promising!

I wanted to try this on https://github.com/ballista-compute/sqlparser-rs on macOS and it failed with:

$ belay
Checking 'cargo fmt -- --check --config-path <(echo 'license_template_path = "HEADER"')':
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `cargo fmt -- --check --config-path <(echo 'license_template_path = "HEADER"')'
Error: "Failed"

I assume this is because belay runs commands with sh -c, while GitHub Actions use bash / powershell by default.

@JoshMcguigan
Copy link
Owner

Hi @nickolay, thanks for the report. Looks like github uses bash with a fallback to sh if bash is not available. I'd be open to a PR implementing this in belay! Bonus if it considers whatever the appropriate behavior for gitlab is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants